From e8d310ebdafa50c942428d4c5ab38eedba7cca86 Mon Sep 17 00:00:00 2001
From: Douglas Barone <douglasvbarone@gmail.com>
Date: Mon, 21 Dec 2020 09:24:58 -0400
Subject: [PATCH] Rename parent var

---
 server/src/resolvers/Group.js        |  2 +-
 server/src/resolvers/Log.js          |  5 +--
 server/src/resolvers/ResetToken.js   | 15 ++++----
 server/src/resolvers/User.js         | 52 +++++++++++++++++-----------
 server/src/resolvers/UserPresence.js |  6 ++--
 server/src/resolvers/WifiDevice.js   |  5 +--
 6 files changed, 51 insertions(+), 34 deletions(-)

diff --git a/server/src/resolvers/Group.js b/server/src/resolvers/Group.js
index 7738a06..4ae3ce3 100755
--- a/server/src/resolvers/Group.js
+++ b/server/src/resolvers/Group.js
@@ -1,5 +1,5 @@
 const Group = {
-  members: (_, args, { ad }) => ad.getUsersForGroup(_.cn)
+  members: (parent, args, { ad }) => ad.getUsersForGroup(parent.cn)
 }
 
 export { Group }
diff --git a/server/src/resolvers/Log.js b/server/src/resolvers/Log.js
index 2b0af48..dab1cb9 100644
--- a/server/src/resolvers/Log.js
+++ b/server/src/resolvers/Log.js
@@ -1,6 +1,7 @@
 const Log = {
-  data: _ => JSON.stringify(_.data),
-  timestamp: _ => _.timestamp?.toISOString()
+  data: parent => JSON.stringify(parent.data),
+
+  timestamp: parent => parent.timestamp?.toISOString()
 }
 
 export { Log }
diff --git a/server/src/resolvers/ResetToken.js b/server/src/resolvers/ResetToken.js
index e19c72a..cd3eda7 100755
--- a/server/src/resolvers/ResetToken.js
+++ b/server/src/resolvers/ResetToken.js
@@ -1,14 +1,17 @@
 import prisma from '../prisma'
 
 const ResetToken = {
-  creator(_) {
-    return prisma.resetToken.findUnique({ where: { id: _.id } }).creator()
+  creator(parent) {
+    return prisma.resetToken.findUnique({ where: { id: parent.id } }).creator()
   },
-  user(_) {
-    return prisma.resetToken.findUnique({ where: { id: _.id } }).user()
+
+  user(parent) {
+    return prisma.resetToken.findUnique({ where: { id: parent.id } }).user()
   },
-  expiration: _ => _.expiration.toISOString(),
-  createdAt: _ => _.createdAt.toISOString()
+
+  expiration: parent => parent.expiration.toISOString(),
+
+  createdAt: parent => parent.createdAt.toISOString()
 }
 
 export { ResetToken }
diff --git a/server/src/resolvers/User.js b/server/src/resolvers/User.js
index b5a813b..1794271 100755
--- a/server/src/resolvers/User.js
+++ b/server/src/resolvers/User.js
@@ -1,39 +1,49 @@
 import prisma from '../prisma'
 
 const User = {
-  firstName: _ => _.displayName.split(' ')[0],
-  displayName: _ => (_.displayName ? _.displayName.capitalize() : ''),
+  firstName: parent => parent.displayName.split(' ')[0],
 
-  groups: async (_, args, { ad }) =>
-    _.groups ? _.groups : ad.getGroupMembershipForUser(_.sAMAccountName),
+  displayName: parent =>
+    parent.displayName ? parent.displayName.capitalize() : '',
 
-  lastLogin: _ => _.lastLogin.toISOString(),
-  lastLoginPrior: _ => _.lastLoginPrior.toISOString(),
-  pwdLastSet: _ => _.pwdLastSet.toISOString(),
+  groups: async (parent, args, { ad }) =>
+    parent.groups
+      ? parent.groups
+      : ad.getGroupMembershipForUser(parent.sAMAccountName),
 
-  sharedFolders: _ =>
-    _.groups
-      ? _.groups
+  lastLogin: parent => parent.lastLogin.toISOString(),
+
+  lastLoginPrior: parent => parent.lastLoginPrior.toISOString(),
+
+  pwdLastSet: parent => parent.pwdLastSet.toISOString(),
+
+  sharedFolders: parent =>
+    parent.groups
+      ? parent.groups
           .filter(group => group.cn.includes('-Share-'))
           .map(group => group.cn.split('-')[2])
       : [],
 
-  sharedPrinters: _ =>
-    _.groups
-      ? _.groups
+  sharedPrinters: parent =>
+    parent.groups
+      ? parent.groups
           .filter(group => group.cn.includes('-Printer-'))
           .map(group => group.cn.split('-')[2])
       : [],
 
-  isSuperAdmin: _ => _.roles.includes('superAdmin'),
-  isTokenCreator: _ => _.roles.includes('tokenCreator'),
-  isServant: _ => _.roles.includes('servant'),
-  isStudent: _ => _.roles.includes('student'),
-  isWatcher: _ => _.roles.includes('watcher'),
+  isSuperAdmin: parent => parent.roles.includes('superAdmin'),
 
-  wifiDevices: (_, data, { auth }) => {
+  isTokenCreator: parent => parent.roles.includes('tokenCreator'),
+
+  isServant: parent => parent.roles.includes('servant'),
+
+  isStudent: parent => parent.roles.includes('student'),
+
+  isWatcher: parent => parent.roles.includes('watcher'),
+
+  wifiDevices: (parent, data, { auth }) => {
     if (
-      _.sAMAccountName !== auth.sAMAccountName &&
+      parent.sAMAccountName !== auth.sAMAccountName &&
       !auth.roles.includes('superAdmin')
     )
       return []
@@ -41,7 +51,7 @@ const User = {
     return prisma.user
       .findUnique({
         where: {
-          sAMAccountName: _.sAMAccountName
+          sAMAccountName: parent.sAMAccountName
         }
       })
       .wifiDevices()
diff --git a/server/src/resolvers/UserPresence.js b/server/src/resolvers/UserPresence.js
index 2ada692..a3b8db3 100644
--- a/server/src/resolvers/UserPresence.js
+++ b/server/src/resolvers/UserPresence.js
@@ -1,6 +1,8 @@
 const UserPresence = {
-  displayName: _ => (_.displayName ? _.displayName.capitalize() : ''),
-  lastSeen: _ => _.lastSeen?.toISOString()
+  displayName: parent =>
+    parent.displayName ? parent.displayName.capitalize() : '',
+
+  lastSeen: parent => parent.lastSeen?.toISOString()
 }
 
 export { UserPresence }
diff --git a/server/src/resolvers/WifiDevice.js b/server/src/resolvers/WifiDevice.js
index f670d92..7d8cc95 100644
--- a/server/src/resolvers/WifiDevice.js
+++ b/server/src/resolvers/WifiDevice.js
@@ -1,6 +1,7 @@
 const WifiDevice = {
-  lastSeen: _ => _.lastSeen?.toISOString(),
-  firstSeen: _ => _.firstSeen?.toISOString()
+  lastSeen: parent => parent.lastSeen?.toISOString(),
+
+  firstSeen: parent => parent.firstSeen?.toISOString()
 }
 
 export { WifiDevice }