From 2d0a72fb36bcd393d438a0183144d99b770ae8fc Mon Sep 17 00:00:00 2001
From: Douglas Barone <douglasvbarone@gmail.com>
Date: Thu, 31 Mar 2022 08:18:08 -0400
Subject: [PATCH] Move controller login outside functions

---
 server/src/lib/unifiController.js | 17 +++--------------
 1 file changed, 3 insertions(+), 14 deletions(-)

diff --git a/server/src/lib/unifiController.js b/server/src/lib/unifiController.js
index 4944bfd..72a0d8f 100644
--- a/server/src/lib/unifiController.js
+++ b/server/src/lib/unifiController.js
@@ -9,6 +9,8 @@ const unifiController = new Controller(
   process.env.UNIFI_PORT || 8443
 )
 
+unifiController.login(process.env.UNIFI_USER, process.env.UNIFI_PASSWORD)
+
 const usedControllerMethods = [
   'login',
   'logout',
@@ -167,11 +169,6 @@ for (let key of usedControllerMethods)
 
 export async function getOnlineWifiDevices() {
   try {
-    await unifiController.login(
-      process.env.UNIFI_USER,
-      process.env.UNIFI_PASSWORD
-    )
-
     const accessPointsPromise = unifiController.getAccessDevices('default')
     const onlineDevicesPromise = unifiController.getClientDevices('default')
 
@@ -195,20 +192,14 @@ export async function getOnlineWifiDevices() {
       controller: 'UniFi'
     }))
 
-    unifiController.logout()
-
     return hydratedOnlineDevices
   } catch (e) {
-    throw new Error('Error getting devices. ' + e)
+    throw new Error('Error getting UniFi devices. ' + e)
   }
 }
 
 export async function getAccessPoints() {
   try {
-    await unifiController.login(
-      process.env.UNIFI_USER,
-      process.env.UNIFI_PASSWORD
-    )
     const accessPoints = await unifiController.getAccessDevices('default')
 
     const restructuredAccessPoints = accessPoints[0].map(
@@ -223,8 +214,6 @@ export async function getAccessPoints() {
       })
     )
 
-    unifiController.logout()
-
     return restructuredAccessPoints
   } catch (e) {
     logError({